Merge lp://qastaging/~mhr3/unity-lens-files/fix-841847 into lp://qastaging/unity-lens-files
Proposed by
Michal Hruby
Status: | Merged |
---|---|
Approved by: | Mikkel Kamstrup Erlandsen |
Approved revision: | 211 |
Merged at revision: | 207 |
Proposed branch: | lp://qastaging/~mhr3/unity-lens-files/fix-841847 |
Merge into: | lp://qastaging/unity-lens-files |
Diff against target: |
782 lines (+314/-280) 3 files modified
configure.ac (+1/-1) src/daemon.vala (+304/-279) src/utils.vala (+9/-0) |
To merge this branch: | bzr merge lp://qastaging/~mhr3/unity-lens-files/fix-841847 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Mikkel Kamstrup Erlandsen (community) | Approve | ||
Review via email:
|
Description of the change
Support selection of multiple filters at once, also simplify various code paths. UNBLOCK
To post a comment you must log in.
Tested against Unity trunk and works very well.
460 +/* get_active_ option ();
461 private string get_current_type ()
462 {
463 - /* Get the current type to filter by */
464 + // Get the current type to filter by
465 var filter = scope.get_filter ("type") as RadioOptionFilter;
466 Unity.FilterOption? option = filter.
467 return option == null ? "all" : option.id;
468 }
469 -
470 +*/
Any specific reason to keep this in?
Apart from the that the code looks great.
On the behavior: One change from the current ways is that the Folders category now lists recent folders after the Gtk bookmarks. Is that intentional? (fwiw, I found use of it already while testing this branch - so if it wasn't on purpose we might want to check with John if we can keep it... :-))