Merge lp://qastaging/~mpt/apport/warmer-text into lp://qastaging/~apport-hackers/apport/trunk
Proposed by
Matthew Paul Thomas
Status: | Merged |
---|---|
Merged at revision: | 2476 |
Proposed branch: | lp://qastaging/~mpt/apport/warmer-text |
Merge into: | lp://qastaging/~apport-hackers/apport/trunk |
Diff against target: |
387 lines (+83/-67) 4 files modified
gtk/apport-gtk (+18/-18) kde/apport-kde (+7/-7) test/test_ui_gtk.py (+37/-25) test/test_ui_kde.py (+21/-17) |
To merge this branch: | bzr merge lp://qastaging/~mpt/apport/warmer-text |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Apport upstream developers | Pending | ||
Review via email: mp+121841@code.qastaging.launchpad.net |
Description of the change
Tweaks the text of many of the error messages to make them a bit friendlier. Thanks to Matt Price for providing advice on the language.
To post a comment you must log in.
Thanks Matthew!
I like the addition of a subtitle for a hanging application.
17 - t = (_('Sorry, the application %s has closed unexpectedly.')
18 + t = (_('The app %s has closed unexpectedly.')
I must say I don't quite like changes like this. We do not call programs "apps" in Ubuntu, and to me this looks like a gratuitous string change which breaks all translations without a real advantage.
Also, we are in UI/string freeze now, so I'd only like to change strings where absolutely necessary.
Please also notice that u'' does not work in Python 3; for using Unicode characters in strings which should work in both Python 2 and 3 we need to use crutches like b'...'. decode( 'UTF-8' ).