Code review comment for lp://qastaging/~mpt/apport/warmer-text

Revision history for this message
Martin Pitt (pitti) wrote :

Thanks Matthew!

I like the addition of a subtitle for a hanging application.

17 - t = (_('Sorry, the application %s has closed unexpectedly.')
18 + t = (_('The app %s has closed unexpectedly.')

I must say I don't quite like changes like this. We do not call programs "apps" in Ubuntu, and to me this looks like a gratuitous string change which breaks all translations without a real advantage.

Also, we are in UI/string freeze now, so I'd only like to change strings where absolutely necessary.

Please also notice that u'' does not work in Python 3; for using Unicode characters in strings which should work in both Python 2 and 3 we need to use crutches like b'...'.decode('UTF-8').

« Back to merge proposal