Merge lp://qastaging/~mterry/snap-confine/fix-tests into lp://qastaging/~snappy-dev/snap-confine/trunk
Proposed by
Michael Terry
Status: | Merged |
---|---|
Approved by: | John Lenton |
Approved revision: | 69 |
Merged at revision: | 67 |
Proposed branch: | lp://qastaging/~mterry/snap-confine/fix-tests |
Merge into: | lp://qastaging/~snappy-dev/snap-confine/trunk |
Diff against target: |
55 lines (+15/-13) 2 files modified
Makefile (+2/-0) src/main.c (+13/-13) |
To merge this branch: | bzr merge lp://qastaging/~mterry/snap-confine/fix-tests |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Michael Vogt (community) | Approve | ||
Tyler Hicks (community) | Approve | ||
Review via email: mp+260618@code.qastaging.launchpad.net |
Commit message
Fix tests to work again.
Description of the change
Fix tests to work again.
They all rely on passing a command like /bin/true or similar in. But these fail the check that the executable must be in /apps, /frameworks, or /oem.
I fixed the tests by ignoring that check when SNAPPY_
I've also enabled tests/test_
To post a comment you must log in.
How about moving the original strstr() tests inside of the if(geteuid() == 0) { ... } block? That will result in the binary path restrictions being in place when the launcher is installed as a setuid root binary. Those restrictions will not be in place during test runs.