Merge lp://qastaging/~renatofilho/unity/unity-lp876017-fixes into lp://qastaging/unity

Ok, nice... It's getting better!
Another thing that must be

23:29:10 <renato> this last point you notice about the string, I do not think this is a good solution since the string is created internally by "XGetWindowProperty" and they recommend to free the memory with XFree

Yeah, but XFree is basically free, so I'd ust glib::String for that too.

Another thing that should be fixed is the titlebar font, You're actually using a sans font, but you should instead use the system font; you can see again QuicklistMenuItem::DrawText how to get the proper font name and dpi values.

An extra nice plus would be to cut the long titles fading them out, there's some code that already does it in PanelMenuView::DrawTitle, give that a test. ;)

> Another thing that should be fixed is the titlebar font, You're actually using
> a sans font, but you should instead use the system font; you can see again
> QuicklistMenuItem::DrawText how to get the proper font name and dpi values.

Err... I didn't remember I wrote Style::Instance().GetFontDescription(PanelItem::TITLE), you can safely use this. See the panelmenuview code for this too ;)

> 23:29:10 <renato> this last point you notice about the string, I do not think
> this is a good solution since the string is created internally by
> "XGetWindowProperty" and they recommend to free the memory with XFree
>
> Yeah, but XFree is basically free, so I'd ust glib::String for that too.
>

Mixing memory allocation functions from multiple libraries isn't a good idea... Yes, right now both XFree and g_free might be just aliases for free(), but that doesn't mean that's always the case. Please keep the XFree.

Mh, I see that the fade is using a linear gradient here, I think you should change it so that it only cuts the exceeding pixels with a small fade effect (as the top bar does).

Ah, another thing... Is it just me or I see the top bar starting one px before the thumbnail x?

http://i.imgur.com/D8nI1.png

> Ah, another thing... Is it just me or I see the top bar starting one px before
> the thumbnail x?
>
> http://i.imgur.com/D8nI1.png

Seeing that too, not all the time though, perhaps a float conversion issue?

> Mh, I see that the fade is using a linear gradient here, I think you should
> change it so that it only cuts the exceeding pixels with a small fade effect
> (as the top bar does).

I'm using the same code used as "PanelMenuView::DrawTitle" which other code are you talking about?

> > Mh, I see that the fade is using a linear gradient here, I think you should
> > change it so that it only cuts the exceeding pixels with a small fade effect
> > (as the top bar does).
>
>
> I'm using the same code used as "PanelMenuView::DrawTitle" which other code
> are you talking about?

Ok I found the problem, fixed on rev. 2658

Hi guys I have fixed the problems, but I found a problem related with maximized windows which is not exactly related with this bug, but produce a bad window drawing. Take a look on this image: http://i.imgur.com/6COGR.jpg

How I can fix it?

> Hi guys I have fixed the problems, but I found a problem related with
> maximized windows which is not exactly related with this bug, but produce a
> bad window drawing. Take a look on this image: http://i.imgur.com/6COGR.jpg
>
> How I can fix it?

Mhm, I think you need make scale to produce smaller windows that consider the height of your decoration.
See if you can set that at scale level and then make unity to define its padding.

I'm still running the Unity Staging PPA version of Unity, any idea why the maximized window decoration cannot be clicked to raise the window ? Un-maximised windows are not affected by this issue.

> I'm still running the Unity Staging PPA version of Unity, any idea why the
> maximized window decoration cannot be clicked to raise the window ? Un-
> maximised windows are not affected by this issue.

yes I have fixed this on rev: 2660, this happen because the maximized window does not have decorations.

That's fine then !

Looks good, further improvements coming into lp:~3v1n0/unity/spread-title-improved

The Jenkins job https://jenkins.qa.ubuntu.com/job/automerge-unity/1205/console reported an error when processing this lp:~renatofilho/unity/unity-lp876017-fixes branch.
Not merging it.

The Jenkins job https://jenkins.qa.ubuntu.com/job/automerge-unity/1210/console reported an error when processing this lp:~renatofilho/unity/unity-lp876017-fixes branch.
Not merging it.

The Jenkins job https://jenkins.qa.ubuntu.com/job/automerge-unity/1212/console reported an error when processing this lp:~renatofilho/unity/unity-lp876017-fixes branch.
Not merging it.