Code review comment for lp://qastaging/~renatofilho/unity/unity-lp876017-fixes

Revision history for this message
Marco Trevisan (TreviƱo) (3v1n0) wrote :

Ok, nice... It's getting better!
Another thing that must be

23:29:10 <renato> this last point you notice about the string, I do not think this is a good solution since the string is created internally by "XGetWindowProperty" and they recommend to free the memory with XFree

Yeah, but XFree is basically free, so I'd ust glib::String for that too.

Another thing that should be fixed is the titlebar font, You're actually using a sans font, but you should instead use the system font; you can see again QuicklistMenuItem::DrawText how to get the proper font name and dpi values.

An extra nice plus would be to cut the long titles fading them out, there's some code that already does it in PanelMenuView::DrawTitle, give that a test. ;)

« Back to merge proposal