Code review comment for lp://qastaging/~renatofilho/unity/unity-lp876017-fixes

Revision history for this message
Michal Hruby (mhr3) wrote :

> 23:29:10 <renato> this last point you notice about the string, I do not think
> this is a good solution since the string is created internally by
> "XGetWindowProperty" and they recommend to free the memory with XFree
>
> Yeah, but XFree is basically free, so I'd ust glib::String for that too.
>

Mixing memory allocation functions from multiple libraries isn't a good idea... Yes, right now both XFree and g_free might be just aliases for free(), but that doesn't mean that's always the case. Please keep the XFree.

« Back to merge proposal