Release Upgrader

Merge lp://qastaging/~rohangarg/ubuntu-release-upgrader/kubuntu into lp://qastaging/ubuntu-release-upgrader

kubuntu
Merge into trunk

Proposed by Rohan Garg on 2014-01-28

Status:	Rejected
Rejected by:	Julian Andres Klode on 2018-01-26
Proposed branch:	lp://qastaging/~rohangarg/ubuntu-release-upgrader/kubuntu
Merge into:	lp://qastaging/ubuntu-release-upgrader
Diff against target:	72 lines (+13/-19) 2 files modified DistUpgrade/DistUpgradeFetcherKDE.py (+12/-15) DistUpgrade/dialog_release_notes.ui (+1/-4)
To merge this branch:	bzr merge lp://qastaging/~rohangarg/ubuntu-release-upgrader/kubuntu
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Harald Sitter		2014-01-28	Needs Fixing on 2014-01-30
Review via email: mp+203595@code.qastaging.launchpad.net

Description of the change

I've modified the KDE release notes ui so that it :

a) Shows the HTML notes in a QWebView
b) Uses an icon for the window

lp://qastaging/~rohangarg/ubuntu-release-upgrader/kubuntu updated on 2014-01-28

2726. By Rohan Garg on 2014-01-28: Use the HTML release notes and a QWebView instead of the regular text release notes

Revision history for this message

Harald Sitter (apachelogger) wrote on 2014-01-30:

19 + self.dialogue.releaseNotesBrowser.setUrl(QUrl(uri))
20 + self.dialogue.releaseNotesBrowser.loadFinished.connect(self.releaseNotesLoaded)

connect first

I am wondering whether there isn't a way to preserve the full error handling the distinction between not being able to get a http reply and not being able to reach the server seems rather useful.

also, was this tested on precise? I am not certain of the webview quality in that relese.

review: Needs Fixing

Revision history for this message

Rohan Garg (rohangarg) wrote on 2014-01-30:

> 19 + self.dialogue.releaseNotesBrowser.setUrl(QUrl(uri))
> 20 + self.dialogue.releaseNotesBrowser.loadFinished.connect(self.releas
> eNotesLoaded)
>
> connect first
>

Will do.

> I am wondering whether there isn't a way to preserve the full error handling
> the distinction between not being able to get a http reply and not being able
> to reach the server seems rather useful.
>

QWebView doesn't offer a detailed error message unfortunately. Though I only had a cursory glance at the API.

> also, was this tested on precise? I am not certain of the webview quality in
> that relese.

Yep. This was tested on precise. Works fine there.

Revision history for this message

Rohan Garg (rohangarg) wrote on 2014-02-07:

Poke?

Revision history for this message

Harald Sitter (apachelogger) wrote on 2014-02-08:

> Poke?

I still only see the same proposal.

FWIW though, ::page() should give you access to most handy error hanlding in qwebview.

Revision history for this message

Julian Andres Klode (juliank) wrote on 2018-01-26:

If there is still something going on, please resubmit a new merge proposal. I rejected that now as it has not seen any activity in 4 years.

Unmerged revisions

2726. By Rohan Garg on 2014-01-28: Use the HTML release notes and a QWebView instead of the regular text release notes
2725. By Rohan Garg on 2014-01-28: Release note fetcher should have an icon
2724. By Launchpad Translations on behalf of ubuntu-core-dev on 2014-01-25: Launchpad automatic translations update.