Code review comment for lp://qastaging/~rohangarg/ubuntu-release-upgrader/kubuntu

Revision history for this message
Rohan Garg (rohangarg) wrote :

> 19 + self.dialogue.releaseNotesBrowser.setUrl(QUrl(uri))
> 20 + self.dialogue.releaseNotesBrowser.loadFinished.connect(self.releas
> eNotesLoaded)
>
> connect first
>

Will do.

> I am wondering whether there isn't a way to preserve the full error handling
> the distinction between not being able to get a http reply and not being able
> to reach the server seems rather useful.
>

QWebView doesn't offer a detailed error message unfortunately. Though I only had a cursory glance at the API.

> also, was this tested on precise? I am not certain of the webview quality in
> that relese.

Yep. This was tested on precise. Works fine there.

« Back to merge proposal