Code review comment for lp://qastaging/~rohangarg/ubuntu-release-upgrader/kubuntu

Revision history for this message
Harald Sitter (apachelogger) wrote :

19 + self.dialogue.releaseNotesBrowser.setUrl(QUrl(uri))
20 + self.dialogue.releaseNotesBrowser.loadFinished.connect(self.releaseNotesLoaded)

connect first

I am wondering whether there isn't a way to preserve the full error handling the distinction between not being able to get a http reply and not being able to reach the server seems rather useful.

also, was this tested on precise? I am not certain of the webview quality in that relese.

review: Needs Fixing

« Back to merge proposal