Merge lp://qastaging/~pfalcon/linaro-android-build-tools/validate-build-conf into lp://qastaging/linaro-android-build-tools
Proposed by
Paul Sokolovsky
Status: | Merged |
---|---|
Merged at revision: | 460 |
Proposed branch: | lp://qastaging/~pfalcon/linaro-android-build-tools/validate-build-conf |
Merge into: | lp://qastaging/linaro-android-build-tools |
Diff against target: |
309 lines (+237/-24) 4 files modified
node/build (+26/-22) node/lava-submit (+1/-2) node/prepare_build_config.py (+114/-0) tests/test_prepare_build_config.py (+96/-0) |
To merge this branch: | bzr merge lp://qastaging/~pfalcon/linaro-android-build-tools/validate-build-conf |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Georgy Redkozubov | Approve | ||
Paul Sokolovsky | Approve | ||
James Tunnicliffe | Pending | ||
Review via email: mp+103118@code.qastaging.launchpad.net |
This proposal supersedes a proposal from 2012-04-20.
Description of the change
This implements validation for build config to accommodate restricted Android builds, per teh previous discussion via email. I initially tried to implement that using bash, but it turned out to be waste of time, as various issues to workaround kept popping up. So, instead I rewrote it in Python, which should make it more robust and maintainable.
Fixed issues pointed out by Georgy, more tests.
To post a comment you must log in.
At least following 2 errors were found:
1) convert_ config_ to_shell( ) takes 1 argument in definition, 2 was given: config = convert_ config_ to_shell( config_ text, get_slave_type())
Looks like you have mixed up 2 functions, please move get_slave_type() form first to second: config_ to_shell( config_ text, get_slave_type())
validate_ config( config)
config = convert_
try:
2) global name 'cfg' is not defined text.split( "\n") instead
for l in cfg.split("\n"):
You should use config_