Merge lp://qastaging/~renatofilho/unity/unity-lp876017-fixes into lp://qastaging/unity
Proposed by
Renato Araujo Oliveira Filho
Status: | Merged |
---|---|
Approved by: | Timo Jyrinki |
Approved revision: | no longer in the source branch. |
Merged at revision: | 2662 |
Proposed branch: | lp://qastaging/~renatofilho/unity/unity-lp876017-fixes |
Merge into: | lp://qastaging/unity |
Diff against target: |
981 lines (+425/-321) 7 files modified
plugins/unityshell/src/unityshell.cpp (+311/-295) plugins/unityshell/src/unityshell.h (+30/-26) unity-shared/PluginAdapter.h (+4/-0) unity-shared/PluginAdapterCompiz.cpp (+67/-0) unity-shared/PluginAdapterStandalone.cpp (+6/-0) unity-shared/WindowManager.cpp (+5/-0) unity-shared/WindowManager.h (+2/-0) |
To merge this branch: | bzr merge lp://qastaging/~renatofilho/unity/unity-lp876017-fixes |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Marco Trevisan (Treviño) | Approve | ||
jenkins | continuous-integration | Pending | |
Review via email:
|
Commit message
UnityWindow: scale window code improved
* Fixed code style.
* Moved function "GetWindowName" from UnityWindow to WindowManager.
* Used glib::Object auto pointer instead of "c" pointer;
Description of the change
* Fixed code style.
* Moved function "GetWindowName" from UnityWindow to WindowManager.
* Used glib::Object auto pointer instead of "c" pointer;
To post a comment you must log in.
Ok, nice... It's getting better!
Another thing that must be
23:29:10 <renato> this last point you notice about the string, I do not think this is a good solution since the string is created internally by "XGetWindowProp erty" and they recommend to free the memory with XFree
Yeah, but XFree is basically free, so I'd ust glib::String for that too.
Another thing that should be fixed is the titlebar font, You're actually using a sans font, but you should instead use the system font; you can see again QuicklistMenuIt em::DrawText how to get the proper font name and dpi values.
An extra nice plus would be to cut the long titles fading them out, there's some code that already does it in PanelMenuView: :DrawTitle, give that a test. ;)